Fix checklist for BCD upgrades workflow #2073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A follow up to web-platform-dx#2043
|
@Elchi3 if you'd have another look at this, I'd appreciate it. 🙏 |
github-actions
bot
added
the
tools and infrastructure
Elchi3
approved these changes
Oct 24, 2024
|
@ddbeck this seems to fail on regular PRs: https://github.com/web-platform-dx/web-features/actions/runs/11499270152
|
ddbeck
added a commit
to ddbeck/web-features
that referenced
this pull request
Oct 24, 2024
Elchi3
pushed a commit
that referenced
this pull request
Oct 24, 2024
vwallen
pushed a commit
to oddbird/web-features
that referenced
this pull request
Nov 5, 2024
vwallen
pushed a commit
to oddbird/web-features
that referenced
this pull request
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow up to #2043.
This workflow on the first attempt: https://github.com/web-platform-dx/web-features/actions/runs/11496579249/job/31998472971?pr=2071#logs
Problems:
To fix this, I did these things:
Switched to using https://github.com/dependabot/fetch-metadata instead (to avoid a slow checkout)
Unfortunately, this makes the PR basically untestable—you can't force Dependabot to do anything. We'll find out if it works tomorrow, I guess.
Set
continue-on-errorfor both steps, since failures of this workflow shouldn't mark the PR as failing